feat: pages not present at build throw 404 #1726
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tris-signoz
changed the title
|
The issue reported in https://github.com/SigNoz/engineering-pod/issues/2689 is resolved by this. 
|
YounixM
reviewed
Jul 28, 2025
| if (child.props.value === activeTab) | ||
| return <div key={child.props.value}>{child.props.children}</div> | ||
| if ((child.props as any).value === selectedTab) | ||
| return <div key={(child.props as any).value}>{(child.props as any).children}</div> |
There was a problem hiding this comment.
Use correct types, avoid using any
YounixM
reviewed
Jul 28, 2025
|
|
||
| export default function TopNavStaticContent() { | ||
| return ( | ||
| <div> |
YounixM
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 PR Summary
When a non-existent page is accessed, the UI correctly renders a "404 - Page Not Found" screen. However, the server responds with a 200 OK status instead of 404 Not Found.
The changes made in the PR solve for this behaviour for the given routes:
Since these pages are also present in sitemap, it is important that they follow SEO guidelines.
✅ Summary of Changes
Declaring "all params are known at build-time" (
export const dynamicParams = falseandexport const dynamic = 'error'added to page.tsx files for dynamic routes)Ref -
https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#dynamicparams
https://nextjs.org/docs/app/api-reference/file-conventions/route-segment-config#dynamic
Components which use useSearchParams() wrapped in a suspense boundary (to avoid CSR bailouts) with a static fallback (to ensure SEO compliance)
Ref -
https://nextjs.org/docs/messages/missing-suspense-with-csr-bailout
https://nextjs.org/docs/app/getting-started/partial-prerendering#dynamic-rendering
Made GrowthBookProvider a client component (uses cookies())
Other refs -
🧪 How to Test
Visit any page on the routes above
🔍 Related Issues
Solves https://github.com/SigNoz/engineering-pod/issues/2689
📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)
Before:
https://github.com/user-attachments/assets/9b15dfb4-f2cc-42cf-9a09-ff6987c19285
After:
https://github.com/user-attachments/assets/3754465e-c9c2-4e17-af88-155aaa9552a5