selfhost: Gotta go fast(er) #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up find_or_add_type_id() using one major observation and
two observations:
- A type does not change significantly once it's created
- The type can have a more lax hash that ignores large parts of the
type
- There aren't that many types with the same lax hash actually
In this commit, the type list in a module gains a skiplist where each
"lane" is reserved for a specific hash; this list grows linearly with
the number of unique hashes, as each entry tracks its own next-in-list
object.
Overall, this is a ~40% performance increase when typechecking the
compiler, and a ~11% increase when typechecking all the tests in the
repository.
Writing these back to disk is slower than parsing the C++, and I don't think they ever actually worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up find_or_add_type_id() using one major observation and
two observations:
type
In this commit, the type list in a module gains a skiplist where each
"lane" is reserved for a specific hash; this list grows linearly with
the number of unique hashes, as each entry tracks its own next-in-list
object.
Overall, this is a ~40% performance increase when typechecking the
compiler, and a ~11% increase when typechecking all the tests in the
repository.