Fixs for Node 4 compatibility #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
RonaldTreur
added a commit
that referenced
this pull request
Nov 28, 2015
Fix for Node v4 compatibility + Node Sass upgraded to v3
RonaldTreur
added a commit
that referenced
this pull request
Nov 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
STSS had some bug since I upgraded from Node 0.12 to 4.X, it seems that upgrade
node-sassand making a little check that I describe bellow resolved the issue.The problem was that sometimes, css2json received
Bufferinstead ofString, andcss-parsegive this variable tocsswithout check.I tried to make a pull request to the
csspackage to make it allow the use of a Buffer or a String, you can see it here : reworkcss/css#81It seems that making this fix in STSS is a better idea, according to the css package author.
Of course I launched a
npm testand all passed with Node 4.2.1, so if you accept my PR I'll be able to work with an official fix instead my manually applied patch, and other STSS users will be able to work with your tool with the latest NodeJS version.Thanks in advance!
Best regards,
Samuel D