Skip to content
This repository has been archived by the owner on Dec 21, 2019. It is now read-only.

Re-added removed vanish, etc. which was just 2 libraries missing. (LEGACY BRANCH) #92

Merged
merged 6 commits into from
Apr 21, 2019

Conversation

Pustalorc
Copy link
Contributor

Honestly, it only needed 2 other UnityEngine libraries to compile again without any complain on vanish, or HUD, or anything really... I have no idea why this wasn't done originally, but whatever. Compiles again and no features are randomly removed.

@Pustalorc Pustalorc changed the title Legacy Re-added removed vanish, etc. which was just 2 libraries missing. (LEGACY BRANCH) Apr 20, 2019
@fr34kyn01535
Copy link
Collaborator

Why exactly did you readd HUD.cs? It was just for testing. Before this gets merged the build script must be changed accordingly.

@Pustalorc
Copy link
Contributor Author

Because you commented it out on your recent commits and you specified on discord that you did so because it didn't compile:

PustalorcToday at 3:01 PM
Sven, may I ask why remove ongui code as well as vanish?
SvenToday at 3:11 PM
feel free to fix it
it didn't compile

"ongui code" was referring to HUD.cs

@Trojaner
Copy link
Member

HUD.cs was added as a test when Nelson introduced client side modules.
Since client side modules got removed again some months ago, there is no need for it all anymore.

@Pustalorc
Copy link
Contributor Author

Removed HUD.cs again in that case then, this time completely and still with the ability to compile Rocket.Unturned.

@fr34kyn01535 fr34kyn01535 merged commit d8219c7 into RocketMod:legacy Apr 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants