This repository has been archived by the owner on Dec 21, 2019. It is now read-only.
Fixed UnturnedPlayerManager.Ban() #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used `Provider.ban()`, which doesn't actually ban the player, only disconnects them from the server as if they were banned (Changed to `SteamBlacklist.ban()` which was correctly used for when the player was offline, but not when online). Also changed `var player = ((UnturnedUser)target).Player;` for `if (target is UnturnedUser user)`. Removed as well the second time it casted Target to UnturnedUser when player was already defined.
Forgot `false` for `return;` and used `user.CSteamID` instead of `player.CSteamID`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used
Provider.ban(), which doesn't actually ban the player, only disconnects them from the server as if they were banned (Changed toSteamBlacklist.ban()which was correctly used for when the player was offline, but not when online).Also changed
var player = ((UnturnedUser)target).Player;forif (!(target is UnturnedUser user)) return false;.Removed as well the second time it casted Target to UnturnedUser when the cast already had happened.