Skip to content
This repository has been archived by the owner on Dec 21, 2019. It is now read-only.

Fix Chat events for regular player chat. #65

Closed
wants to merge 1 commit into from

Conversation

cartman-2000
Copy link
Contributor

This fixes the events for normal player chat, and adds the isRich to the OnPlayerChatted event. Plugins that use the OnPlayerChatted would need to update.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2018

CLA assistant check
All committers have signed the CLA.

@Trojaner
Copy link
Member

Trojaner commented Feb 16, 2018

The OnPlayerChatted "rich" parameter has not been adapted on purpose, to keep backwards compatibililty.
The handler has been already fixed, as "tellChat" SteamCalls have been:
5f6671c
62cd8e8

(This PR wouldn't solve the encoding bug on chat, as it does not fix tellChat missing parameter)

@Trojaner
Copy link
Member

Trojaner commented Feb 17, 2018

For OnPlayerChatted we either need to create a new, additional event - or break many plugins.

Yes, the parameter needs to be added sooner or later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants