Skip to content
This repository has been archived by the owner on Dec 21, 2019. It is now read-only.

Changes #62

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Changes #62

merged 1 commit into from
Feb 23, 2018

Conversation

Pustalorc
Copy link
Contributor

Removed orderby(x => x.Priority) as it should be handled by the permissions provider directly.
Changed firstordefault from x.Prefix != null to !string.IsNullOrEmpty(x.Prefix) so that if the prefix is empty, a prefix/suffix is still applied if any exists elsewhere.

Removed orderby(x => x.Priority) as it should be handled by the permissions provider directly.
Changed firstordefault from x.Prefix != null to !string.IsNullOrEmpty(x.Prefix) so that if the prefix is empty, a prefix/suffix is still applied if any exists elsewhere.
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2018

CLA assistant check
All committers have signed the CLA.

@aviadmini
Copy link
Contributor

Checking prefix change makes sense
I'm not sure about the ordering, but it's probably better when this gives permission provider the control over groups

@Trojaner Trojaner requested a review from fr34kyn01535 February 9, 2018 14:36
@fr34kyn01535 fr34kyn01535 merged commit 59a4e54 into RocketMod:master Feb 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants