fix(con): add maxLength for the expectations field of the profile #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katamatata
changed the title
katamatata
deleted the
fix/con/add-maxLength-for-expectation-section-in-the-profile
branch
katamatata
moved this from Waiting for Deployment
to Done & Deployed
in CON: ReDI Connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Github issue does this PR relate to? Insert link.
No issue.
What should the reviewer know?
In Salesforce, the
Expectationsfield in theReDI Connect profileobject has the maximum length set to 1000 characters. Currently, when users attempt to enter more than 1000 characters, they are unable to save that section of the profile and see no validation error because the maximum length for that field hasn't been set in the codebase.In this PR, we add the
maxLengthproperty to theExpectationsfield, setting the maximum number of characters allowed and notifying users accordingly.Screenshots