Fix rate limiter window reset and usage timing in GatewayRatelimiter #10213
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the internal logic of the
GatewayRatelimiter
to ensure more accurate and consistent rate-limiting behavior.Key Fixes:
Why it matters:
Previously, if the rate-limit window was not reset properly while
remaining
was, the calculated delay could be incorrectly zero, causing shards to reconnect instantly without actually waiting for the rate limit to reset. This could result in:This could result in:
This fix ensures the shards respect the intended cooldown window, improving overall stability and compliance with Discord’s Gateway rate limits.
Checklist