Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components, protocol-designer): Update translations according to initial pre-DQA copy/style pass #17333

Merged
merged 3 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/src/organisms/DeckLabelSet/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ const DeckLabelSetComponent = (
? deckLabels.map((deckLabel, index) => (
<DeckLabel
key={`DeckLabel_${index}`}
maxWidth={`calc(${width}px - ${SPACING.spacing16})`}
maxWidth={`calc(${width}px - 8px)`}
{...deckLabel}
isLast={deckLabels.length - 1 === index}
/>
Expand All @@ -72,7 +72,7 @@ const StyledBox = styled(Box)<StyledBoxProps>`
`

const LabelContainer = styled.div`
padding-left: ${SPACING.spacing12};
padding-left: ${SPACING.spacing8};
& > *:not(:first-child):not(:last-child) {
border-bottom-right-radius: ${BORDERS.borderRadius4};
border-top-right-radius: ${BORDERS.borderRadius4};
Expand Down
6 changes: 3 additions & 3 deletions protocol-designer/src/assets/localization/en/alert.json
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,15 @@
},
"ABSORBANCE_READER_NO_INITIALIZATION": {
"title": "Missing Absorbance Plate Reader initialization step",
"body": "The Absorbance Plate Reader must be initialized before reading labware. Initialize the Absorbance Plate Reader module or remove this step to proceed."
"body": "This step tries to read labware without initializing the Absorbance Plate Reader first. Initialize the Absorbance Plate Reader module or remove this step in order to proceed."
},
"ABSORBANCE_READER_LID_CLOSED": {
"title": "Absorbance Plate Reader Module lid closed",
"body": "This step tries to use labware in the Absorbance Plate Reader. Open the lid before this step."
},
"ABSORBANCE_READER_NO_GRIPPER": {
"title": "Cannot change lid state without gripper",
"body": "This step involves opening or closing the Absorbance Plate Reader lid with a gripper. Add a gripper or remove step to proceed."
"title": "Cannot change Absorbance Plate Reader lid state without gripper",
"body": "The gripper is required to open or close the plate reader lid. Add a gripper or remove this step to proceed."
}
},
"warning": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"unauthorized_verification_failure": "This unique link has expired and is no longer valid, to have a new link sent to your email, fill out the form below.",
"validation_server_failure": "There was a problem communicating with the Opentrons validation server. Please make sure you are still connected to the internet and try again. If this problem persists, please contact Opentrons support."
},
"new_location": "new location",
"new_location": "New location",
"next": "Next",
"no_batch_edit_shared_settings": "Batch editing of settings is only available for Transfer or Mix steps",
"organization_author": "Organization/Author",
Expand Down
7 changes: 5 additions & 2 deletions protocol-designer/src/assets/localization/en/form.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@
"label": "Add a wavelength"
},
"color_parentheses": "({{color}})",
"current_initialization_settings": "Current initialization settings",
"current_initialization_settings": {
"title": "Current initialization settings",
"tooltip": "Module must be empty to change initialization settings"
},
"custom_wavelength": {
"caption": "Value between 350 - 1000 nm",
"label": "Custom wavelength"
Expand All @@ -47,7 +50,7 @@
"wavelength_out_of_range": "Value falls outside of accepted range"
},
"export_settings": {
"description": "A .csv file will appear upon protocol completion in your downloads folder.",
"description": "Absorbance Plate Reader data is saved as a .csv file and can be found on the robot's detail page in the Desktop App.",
"title": "Export settings"
},
"initialization_setting": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export function DropdownStepFormField(
const handleSelection = (value: string): void => {
let text = t('application:selected')
if (fieldName === 'newLocation') {
text = t('application:location')
text = t('application:new_location')
} else if (fieldName === 'aspirate_labware') {
text = t('application:source')
} else if (fieldName === 'dispense_labware') {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export function DeckItemHighlight(
<DeckLabelSet
deckLabels={[
{
text: t('location'),
text: t('new_location'),
isLast: true,
isSelected: isSelected,
isZoomed: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ import {
ListItem,
StyledText,
InfoScreen,
ALIGN_CENTER,
Icon,
useHoverTooltip,
Tooltip,
COLORS,
} from '@opentrons/components'
import { ABSORBANCE_READER_COLOR_BY_WAVELENGTH } from '../../../../../../constants'
import type { Initialization } from '../../../../../../step-forms/types'
Expand Down Expand Up @@ -46,6 +51,7 @@ export function InitializationSettings(
): JSX.Element {
const { initialization } = props
const { t } = useTranslation(['application', 'form'])
const [targetProps, tooltipProps] = useHoverTooltip()
const content =
initialization == null ? (
<InfoScreen
Expand Down Expand Up @@ -95,11 +101,21 @@ export function InitializationSettings(
gridGap={SPACING.spacing4}
width="100%"
>
<StyledText desktopStyle="bodyDefaultSemiBold">
{t(
'form:step_edit_form.absorbanceReader.current_initialization_settings'
)}
</StyledText>
<Flex gridGap={SPACING.spacing8} alignItems={ALIGN_CENTER}>
<StyledText desktopStyle="bodyDefaultSemiBold">
{t(
'form:step_edit_form.absorbanceReader.current_initialization_settings.title'
)}
</StyledText>
<Flex {...targetProps}>
<Icon size="1rem" name="information" color={COLORS.grey60} />
</Flex>
<Tooltip tooltipProps={tooltipProps}>
{t(
'form:step_edit_form.absorbanceReader.current_initialization_settings.tooltip'
)}
</Tooltip>
</Flex>
{content}
</Flex>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export function LabwareLocationField(
dispatch(
hoverSelection({
id,
text: t('application:location'),
text: t('application:new_location'),
})
)
}}
Expand Down
Loading