fix(components,-protocol-designer): fix order and border radius logic for DeckLabelSet #17230
+32
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for DeckLabelSet This PR updates the order in which elements of a module/adapter/labware stack are displayed. The correct order should be top-down, reflecting the physical orientation of the elements on the deck. Also, this PR fixes the border radii of each label in the set according to designs. Closes RQA-3736
|
minor bug, seems to only fail with adapters on the deck. works fine with adapters on a mondule 
|
koji
reviewed
Jan 9, 2025
| text: def.metadata.displayName, | ||
| isSelected: true, | ||
| isLast: hoveredLabware == null && selectedNestedLabwareDefUri == null, | ||
| const hoverLabelLabel = { |
There was a problem hiding this comment.
typo! i will fix. thanks
koji
reviewed
Jan 9, 2025
There was a problem hiding this comment.
props in this component aren't optional so I recommend you use === / !== instead of ==/!=
jerader
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the order in which elements of a module/adapter/labware stack are displayed. The correct order should be top-down, reflecting the physical orientation of the elements on the deck. Also, this PR fixes the border radii of each label in the set according to designs.
Specifically, the order from top-down should be:
Border radii (all 4px) should be:
Closes RQA-3736
Test Plan and Hands on Testing
Changelog
Review requests
see test plan
Risk assessment
low