Skip to content

feat: add osinfo api #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

feat: add osinfo api #441

merged 4 commits into from
Jul 7, 2025

Conversation

nini22P
Copy link
Contributor

@nini22P nini22P commented Jul 6, 2025

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nini22P, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application by adding an API to fetch operating system details, which is then utilized to display the current platform in the 'About' section. Furthermore, it implements a crucial platform-specific restriction, disabling the executable export option when the application is running on Android.

Highlights

  • New API Endpoint: I've introduced a new API endpoint (/api/osinfo) to retrieve operating system information, specifically the platform name. This is exposed via a new OsInfoDto data transfer object.
  • About Component Enhancement: The 'About' component now displays the current operating system platform, fetching this information using the newly added API.
  • Platform-Specific Export Disablement: The option to export executable files has been conditionally disabled for Android platforms, addressing issue #378 and preventing incompatible exports.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new API endpoint to retrieve operating system information. This information is then displayed in the "About" component and used to conditionally disable the "Export as executable" feature on Android platforms. The backend implementation is clean and well-documented. The frontend correctly consumes the new API. My feedback focuses on improving code structure by relocating shared logic and addressing missing translations for a complete user experience.

@MakinoharaShoko MakinoharaShoko merged commit 33f8aeb into OpenWebGAL:dev Jul 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants