Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 workflow farmer registry #696

Open
wants to merge 31 commits into
base: 1-registry-sri-lanka
Choose a base branch
from

Conversation

reichie020212
Copy link
Member

Why is this change needed?

How was the change implemented?

New unit tests

Unit tests executed by the author

How to test manually

Related links

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 64.17910% with 72 lines in your changes missing coverage. Please review.

Project coverage is 76.15%. Comparing base (e2e3314) to head (afe730c).

Files with missing lines Patch % Lines
spp_programs/models/g2p_entitlement.py 40.90% 24 Missing and 2 partials ⚠️
spp_programs/wizard/reject_entitlement_wizard.py 60.86% 18 Missing ⚠️
spp_programs/wizard/reset_to_pending_wizard.py 60.52% 15 Missing ⚠️
spp_registry_approval/models/res_partner.py 52.63% 9 Missing ⚠️
spp_openid_vci/wizard/vci_issuer_selection.py 0.00% 2 Missing ⚠️
spp_openid_vci/models/res_partner.py 87.50% 1 Missing ⚠️
...ograms/wizard/multi_entitlement_approval_wizard.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           1-registry-sri-lanka     #696      +/-   ##
========================================================
- Coverage                 76.25%   76.15%   -0.10%     
========================================================
  Files                       687      699      +12     
  Lines                     17777    17960     +183     
  Branches                   2205     2226      +21     
========================================================
+ Hits                      13556    13678     +122     
- Misses                     3773     3830      +57     
- Partials                    448      452       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reichie020212 reichie020212 force-pushed the 2-workflow-farmer-registry branch from 29b8d9e to afe730c Compare December 24, 2024 10:28
@reichie020212 reichie020212 changed the base branch from 17.0 to 1-registry-sri-lanka December 24, 2024 10:29
@gonzalesedwin1123
Copy link
Member

@reichie020212 Please check the codecov report.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants