-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a minor error with standardization of SNPs when copying #138
base: master
Are you sure you want to change the base?
Conversation
to hold probabilities
value simulation
Centering and scaling were not being performed when copying SnpLinAlg into a numeric matrix with mean imputation.
I'm not sure about the point of this PR. Could you explain more about it? The original code imputes the missing value with the column mean, and the proposed code imputes the missing value with zero when |
I think the modified code does impute with column mean, and return zero when In the below test, (lines 288, 299 and 300 in
we are checking whether the mean imputation is performed and is approximately equal to 1.113. The test should actually check whether |
Centering and scaling were not being performed when copying SnpLinAlg into a numeric matrix with mean imputation.