Skip to content

[18.0][MIG] web_sheet_full_width: Migration to 18.0 #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: 18.0
Choose a base branch
from

Conversation

MohamedOsman7
Copy link

PR v17: #2838

hbrunn and others added 29 commits May 28, 2025 07:45
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
- Add margin for better visibility
- Add web_sheet_full_width migration state Done
- Update to new OCA README.rst format.
[MIG] adapt web_sheet_full_width to V10.0 web framework
* less -> scss
* fragment readme + add a pointer to web_responsive
More specifically, in web_enterprise the selector .o_form_view.o_xxl_form_view > .o_form_sheet_bg > .o_form_sheet fixes the width and has more specificity than this one
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_sheet_full_width
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_sheet_full_width/
@MohamedOsman7 MohamedOsman7 force-pushed the 18.0-mig-web_sheet_full_width branch from 821bb64 to 6f32f0d Compare May 28, 2025 08:34
@MohamedOsman7
Copy link
Author

@anmarmo1, @zamberjo could you please make a review

@MohamedOsman7 MohamedOsman7 mentioned this pull request May 28, 2025
36 tasks
@anmarmo1
Copy link

I'm not sure this module is necessary yet; I don't see any noticeable changes, at least in the Community version.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @anmarmo1. Under what circumstances does this module make a visible difference? Also, this module contains an older recommendation to use web_responsive instead, which reads like a deprecation warning. That makes a strong case to discontinue the module.

max-width: none !important;
width: auto !important;
}
.o_FormRenderer_chatterContainer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class no longer seems used after Odoo 16.

@StefanRijnhart
Copy link
Member

Gotta correct myself here: this module is effective when web_chatter_position is installed. Installing web_chatter_position and forcing the chatter downwards frees up space on the side of the form, but it is this module that allows the main form view use that space. If that is your use case as well, maybe we could consider moving the CSS into web_chatter_position instead.

@MohamedOsman7
Copy link
Author

Moved to #3183

@MohamedOsman7 MohamedOsman7 marked this pull request as draft June 4, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.