[18.0] [MIG] project_task_default_stage: Migration to 18.0 #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_BR/
Currently translated at 100,0% (16 of 16 strings) Translation: project-11.0/project-11.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-11-0/project-11-0-project_task_default_stage/pt_PT/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/gl/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/es/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/de/
Currently translated at 100.0% (17 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/pt_BR/
Currently translated at 94.1% (16 of 17 strings) Translation: project-12.0/project-12.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_default_stage/it/
Currently translated at 100.0% (17 of 17 strings) Translation: project-13.0/project-13.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_default_stage/ca/
Currently translated at 100.0% (20 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/es_AR/
Currently translated at 80.0% (16 of 20 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr_FR/
Currently translated at 100.0% (17 of 17 strings) Translation: project-14.0/project-14.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_default_stage/fr/
Currently translated at 88.2% (15 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/it/
Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/hr/
Currently translated at 100.0% (17 of 17 strings) Translation: project-16.0/project-16.0-project_task_default_stage Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_default_stage/de/
Borruso
force-pushed
the
18.0-mig-project_task_default_stage
branch
from
418d38d to
79875ec
Compare
zamberjo
reviewed
Nov 27, 2024
| <field | ||
| name="auto_validation_state" | ||
| optional="hide" | ||
| groups="project.group_project_rating" |
There was a problem hiding this comment.
The groups was not in previous versions, why add it?
There was a problem hiding this comment.
I saw list in Odoo and Odoo add this group
I can also remove it there is no problem
There was a problem hiding this comment.
No, if it is added by Odoo I see it consistent to apply the same groups.
coleste
reviewed
Dec 16, 2024
| @@ -10,8 +10,8 @@ | |||
| </field> | |||
| </field> | |||
| </record> | |||
| <record id="task_type_tree" model="ir.ui.view"> | |||
| <field name="name">project.task.type.tree.inherit</field> | |||
| <record id="task_type_list" model="ir.ui.view"> | |||
There was a problem hiding this comment.
That doesn't seem right. id= should be the same as that of the inherited.
Borruso
force-pushed
the
18.0-mig-project_task_default_stage
branch
from
79875ec to
3da8cda
Compare
|
This PR has the |
|
/ocabot migration project_task_default_stage |
rousseldenis
requested changes
Dec 20, 2024
| ids = self.env["project.task.type"].search([("case_default", "=", True)]) | ||
| return ids | ||
|
|
||
| type_ids = fields.Many2many(default=lambda self: self._get_default_type_common()) |
project_task_default_stage/tests/test_project_task_default_stage.py
Outdated
Show resolved
Hide resolved
Borruso
force-pushed
the
18.0-mig-project_task_default_stage
branch
from
3da8cda to
49dff3f
Compare
BT-fgarbely
added a commit
to brain-tec/project
that referenced
this pull request
Jan 13, 2025
carlos-lopez-tecnativa
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Tested, LGTM
TT54238
@Tecnativa @pedrobaeza I think this PR is ready for merge. The comment from @rousseldenis related to placing the field at the top of the file, before the default function, should not be blocking. Let's continue with the merge please if it's OK with you. @rousseldenis, could you update your review, please?
@Borruso, if you can apply the suggestions from @rousseldenis, that would be great. Additionally, I think it's possible to squash some of the administrative commits (not blocking).
pedrobaeza
approved these changes
Feb 8, 2025
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 130d8c2. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 17.0 to 18.0
Issue: #1347