Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] project_risk: Migration to 16.0 #1381

Merged
merged 21 commits into from
Feb 9, 2025

Conversation

HeliconiaSolutions
Copy link

No description provided.

tarteo and others added 20 commits November 26, 2024 11:20
[FIX] Lint

[ADD] Tests

[IMP] Small improvements

[IMP] Clearer roadmap
Currently translated at 89.4% (68 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 89.4% (68 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 89.4% (68 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 89.4% (68 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/sl/
Currently translated at 100.0% (76 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/sl/
Currently translated at 100.0% (76 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Currently translated at 100.0% (76 of 76 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/
Currently translated at 100.0% (75 of 75 strings)

Translation: project-13.0/project-13.0-project_risk
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_risk/it/
Copy link

@coleste coleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@Daniel-Melian Daniel-Melian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally reviewed, LGTM.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HeliconiaSolutions
Copy link
Author

Hi @dreispt

Could you please review this pull request when you have a moment? I would appreciate any feedback or suggestions for improvement.

Thank you for your time!

@dreispt
Copy link
Member

dreispt commented Dec 18, 2024

/ocabot migration project_risk
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 18, 2024
OCA-git-bot added a commit that referenced this pull request Dec 18, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1381-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1381-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@HeliconiaSolutions
Copy link
Author

Dear @dreispt,

I hope this message finds you well.

I would like to bring to your attention an issue concerning the PR I recently submitted. When I initially created the PR, all test cases passed successfully. However, after OCABot attempted to merge the PR, the tests are now failing.

I kindly request your assistance in investigating this matter to understand the cause of these failures. Please let me know if I may have overlooked something or if there’s any action required on my part to resolve this issue.

Thank you for your time and support.

@HeliconiaSolutions
Copy link
Author

Hi @dreispt,

In the meantime, I have identified a solution and updated the test cases accordingly. Everything now appears to be in order, and the tests are passing successfully.

Could you kindly review the updates and, if everything looks good, proceed with merging the PR?

Thank you for your time and assistance!

@dreispt
Copy link
Member

dreispt commented Feb 9, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1381-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 480dee8 into OCA:16.0 Feb 9, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 36b8cc1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.