[18.0] [MIG] account_tax_balance: Migration to 18.0 #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tests * PEP8 * Use invoice._convert_to_write(invoice._cache). This way, the onchange will be inheritable and will add here also the added values * better get_context_values * unify method compute_balance * open move lines linked to balance
Allow to explore all move lines Spanish translation Bugfixes Show negative lines too Show move type in account.move views Tests include new fields
* Test * README * add extra parent menu. If not, with the web_responsive module is mixed between other menus
Let the database do some computations (sum) and do not put large lists of ids in action domain.
This indexes improve the display time of account_tax_balance by a factor of 10 on a database with 1M move lines.
On certain environments, expense account might not exist, so we create it directly for avoiding problems.
Tests failed if you don't have an account called 'Tax Paid' in your test DB, which can happen when you are integrating tests in other environments, for example with other starting language.
Precreate move_type and fill with appropriate values to prevent a MemoryError when the ORM attempts to call its compute method on a large amount of preexisting moves.
Currently translated at 100.0% (51 of 51 strings) Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_tax_balance Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_tax_balance/it/
Currently translated at 56.8% (29 of 51 strings) Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_tax_balance Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_tax_balance/ca/
|
/ocabot migration account_tax_balance |
|
/ocabot rebase |
|
Congratulations, PR rebased to 18.0. |
OCA-git-bot
force-pushed
the
18.0-mig-account_tax_balance
branch
from
c46fab2 to
e65233f
Compare
|
This PR has the |
pedrobaeza
requested changes
Feb 11, 2025
Borruso
force-pushed
the
18.0-mig-account_tax_balance
branch
from
e65233f to
f7ec59a
Compare
Borruso
force-pushed
the
18.0-mig-account_tax_balance
branch
from
f7ec59a to
431f564
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 1ac2f42. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from 17.0 to 18.0
Issue: #1230