fix: table collection padding calculation #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alaycock
changed the title
alaycock
force-pushed
the
fix-collection-spacing
branch
from
088135c to
0391c01
Compare
alaycock
force-pushed
the
fix-collection-spacing
branch
from
0391c01 to
9912c17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The padding calculation for a "table collection" is incorrect for pages with a width other than 708. The renderer should allow this to be overridden. For example, your own site uses 900px for
--notion-max-width.My proposed fix is to pass in a
pageWidthproperty to the renderer. An alternative would be to query the width of thediv.notion-page-contentelement on the page. This felt less intrusive.Screenshot: Over-calculated padding, due to the default page width
This PR solves also two more bugs impacting the padding calculation:
useWindowSize, usingwindow.width, includes the scrollbar width as part of the page width. Instead,document.documentElement.clientWidthcan be used for just the document width.The table is too wide on narrow screens, caused by the additional two bugs above
Notion Test Page ID
https://adaminthehills.notion.site/Hi-I-m-Adam-164d424ea49f80c9b216c4425ca573c8?pvs=4