sequoia-nixbld-user-migration: Try to recreate all missing users instead of just first contiguous set #13058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of just first contiguous set This script mostly worked for me, but the nixbld6 and nixbld7 accounts for me were still missing. Looking at the script, it seems it's because of the `until` loop in step 2. It assumes only the first contiguous set of users would have disappeared. So 6 and 7 were never restored. This just runs through all 32 users and ensures they exist. From: NixOS#10892 (comment)
|
The reason the script doesn't hardcode 32 is that you can technically customize the number of nixbld. users at install time. 32 is certainly normal, but there are inevitably people out there with 8 or 16 or 40 and so on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Before: Steps 1 - 3 complete and all nix user accounts 1-32 are listed with updated UIDs except _nixbld6 and _nixbld7.
After: Users 6 and 7 get created and my Nix builds no longer fail.
Context
This script mostly worked for me, but the nixbld6 and nixbld7 accounts for me were still missing. Looking at the script, it seems it's because of the
untilloop in step 2. It assumes only the first contiguous set of users would have disappeared. So 6 and 7 were never restored. This just runs through all 32 users and ensures they exist.From: #10892 (comment)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.