Skip to content

Include audit info when loading table from Polaris #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

bryanck
Copy link
Contributor

@bryanck bryanck commented Jul 1, 2025

This PR includes table audit information in load table responses for Polaris, even when the flag to only include metadata location is present. The audit information is already loaded and does not require loading the Iceberg table. Also it is relatively small, so should have a negligible impact on performance.

Adding this allows us to capture audit fields in batch without loading the Iceberg table, for example, when running our table inventory process.

@bryanck bryanck requested a review from Copilot July 1, 2025 22:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds audit information to table load responses when only metadata location is requested in Polaris.

  • Populates auditInfo from existing data in the metadata-only branch.
  • Avoids extra Iceberg table loads by reusing already-fetched audit fields.
Comments suppressed due to low confidence (2)

metacat-connector-polaris/src/main/java/com/netflix/metacat/connector/polaris/PolarisConnectorTableService.java:173

  • Add or update a unit test to verify that auditInfo is correctly populated when includeMetadataLocationOnly is true, to prevent regressions in this new behavior.
                        .auditInfo(info.getAudit())

metacat-connector-polaris/src/main/java/com/netflix/metacat/connector/polaris/PolarisConnectorTableService.java:170

  • Update the JavaDoc for this method or branch to document that auditInfo will now be included when includeMetadataLocationOnly is enabled, ensuring the behavior is clear to future readers.
            if (connectorContext.getConfig().shouldFetchOnlyMetadataLocationEnabled()

@bryanck bryanck merged commit c942098 into master Jul 2, 2025
3 checks passed
@bryanck bryanck deleted the include-audit-info branch July 2, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants