-
Notifications
You must be signed in to change notification settings - Fork 573
enhancement(events): prompt assignee for triage in Slack #6032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a reminder prompt for case assignees to complete security event triage in Slack, incorporates a new “visibility” field into case update modals, and wires up an escalate-case
slash command.
- Map
escalate_case
command to Slack slash commands - Introduce
case_visibility_select
field and handle it in the update modal/submission - Add
send_event_update_prompt_reminder
and invoke it in the new case flow
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/dispatch/plugins/dispatch_slack/plugin.py | Register escalate_case in Slack command mappings |
src/dispatch/plugins/dispatch_slack/fields.py | Define case_visibility_select enum and builder function |
src/dispatch/plugins/dispatch_slack/case/interactive.py | Add “Update Case” button handler, inject visibility into modal, and process it on submit |
src/dispatch/plugins/dispatch_slack/case/enums.py | Add new CaseNotificationActions.update |
src/dispatch/conversation/enums.py | Add new ConversationCommands.escalate_case |
src/dispatch/case/messaging.py | Implement send_event_update_prompt_reminder |
src/dispatch/case/flows.py | Invoke the new reminder step in case_new_create_flow |
Comments suppressed due to low confidence (1)
src/dispatch/case/messaging.py:381
- Consider adding unit tests or an integration test for
send_event_update_prompt_reminder
to ensure ephemeral messages are sent under expected conditions.
def send_event_update_prompt_reminder(case: Case, db_session: Session) -> None:
Co-authored-by: Copilot <[email protected]> Signed-off-by: Aaron Herman <[email protected]>
…ispatch into feat/prompt-for-triage
Co-authored-by: Copilot <[email protected]> Signed-off-by: Aaron Herman <[email protected]>
…ispatch into feat/prompt-for-triage
This pull request includes adding functionality to prompt assignees to update security events and adds a "visibility" field for case updates in Slack.
Workflow Enhancements:
send_event_update_prompt_reminder
tocase_new_create_flow
insrc/dispatch/case/flows.py
and insrc/dispatch/case/messaging.py
to remind assignees to update security event details during triage, which sends an ephemeral Slack message to the assignee with a button to update case details.Slack Integration Updates:
escalate_case
command toConversationCommands
insrc/dispatch/conversation/enums.py
and mapped it to Slack configurations. [1] [2]update_case_button_click
handler insrc/dispatch/plugins/dispatch_slack/case/interactive.py
to process the "Update Case" button click and open the update modal.Case Visibility Field:
case_visibility_select
functionality insrc/dispatch/plugins/dispatch_slack/fields.py
to allow users to choose "Restricted" or "Open" visibility for cases.handle_edit_submission_event
insrc/dispatch/plugins/dispatch_slack/case/interactive.py
to process the visibility field and save changes.