Skip to content

remove obsolete maxProjectionDepth #826 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
+0 −14
Merged

remove obsolete maxProjectionDepth #826 #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion graphql-dgs-codegen-core/src/main/kotlin/com/netflix/graphql/dgs/codegen/CodeGen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,6 @@ class CodeGenConfig(
var shortProjectionNames: Boolean = false,
var generateDataTypes: Boolean = true,
var omitNullInputFields: Boolean = false,
var maxProjectionDepth: Int = 10,
var kotlinAllFieldsOptional: Boolean = false,
/** If enabled, the names of the classes available via the DgsConstant class will be snake cased.*/
var snakeCaseConstantNames: Boolean = false,
Expand Down
9 changes: 0 additions & 9 deletions ...core/src/test/kotlin/com/netflix/graphql/dgs/codegen/clientapi/ClientApiGenBuilderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
),
).generate()

Expand Down Expand Up @@ -75,7 +74,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
),
).generate()

Expand Down Expand Up @@ -107,7 +105,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
),
).generate()

Expand Down Expand Up @@ -137,7 +134,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
),
).generate()

Expand Down Expand Up @@ -176,7 +172,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
addDeprecatedAnnotation = true,
),
).generate()
Expand Down Expand Up @@ -222,7 +217,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
addDeprecatedAnnotation = true,
),
).generate()
Expand Down Expand Up @@ -274,7 +268,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
addDeprecatedAnnotation = true,
),
).generate()
Expand Down Expand Up @@ -328,7 +321,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
addDeprecatedAnnotation = true,
),
).generate()
Expand Down Expand Up @@ -384,7 +376,6 @@ class ClientApiGenBuilderTest {
schemas = setOf(schema),
packageName = BASE_PACKAGE_NAME,
generateClientApiv2 = true,
maxProjectionDepth = 2,
),
).generate()

Expand Down
4 changes: 0 additions & 4 deletions ...codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/GenerateJavaTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,6 @@ open class GenerateJavaTask
@Input
var omitNullInputFields = false

@Input
var maxProjectionDepth = 10

@Input
var kotlinAllFieldsOptional = false

Expand Down Expand Up @@ -216,7 +213,6 @@ open class GenerateJavaTask
shortProjectionNames = shortProjectionNames,
generateDataTypes = generateDataTypes,
omitNullInputFields = omitNullInputFields,
maxProjectionDepth = maxProjectionDepth,
kotlinAllFieldsOptional = kotlinAllFieldsOptional,
snakeCaseConstantNames = snakeCaseConstantNames,
implementSerializable = implementSerializable,
Expand Down
Loading