-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve photonics documentation #2502
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Omar Bacarreza <[email protected]>
Signed-off-by: Omar Bacarreza <[email protected]>
Signed-off-by: Omar Bacarreza <[email protected]>
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Omar Bacarreza <[email protected]>
a3177c8
to
44c9a4c
Compare
Signed-off-by: Omar Bacarreza <[email protected]>
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
@mawolf2023 for reviewing documentation structure. |
Wow, tricky to decide where to sort this in the docs. I could see a case made to list the photonics simulator with the other simulators. However, my gut thinks we group all of this new material under photonics, especially if it is an ORCA specific simulator. So in the reorganized backends , we have ORCA under the hardware->photonics tab. I say we let this photonics page introduce the orca simulator and show all of the examples. Then the example notebook in this PR could be transformed a bit into a simple application that shows the utility of the photonics simulator. That way it dose not get buried that CUDA-Q can now simulator photonics, but avoids confusing the backend or example sections. Thoughts @efratshabtai @khalatepradnya ? |
Thanks, @Omar-ORCA , for the updates!
With CUDA-Q v0.9.1, the library mode isn't default and must be explicitly set. |
Thanks, @mawolf2023 for the feedback. I think it may come to which PR gets merged first. Are you close to getting yours in? |
I just wanted to make clear that the photonics simulator is not ORCA specific, it can be used to simulate any photonic circuit. |
@Omar-ORCA Thank you for clarifying. In that case, @khalatepradnya and @efratshabtai, I think we add a tab in the SV simulator section for photonics and include all the examples here. Then, we could still update the applications section with a photonics application. @khalatepradnya, I think the backend PR is nearly ready to merge, so probably this one can merge into that? |
Signed-off-by: Omar Bacarreza <[email protected]>
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Pradnya Khalate <[email protected]>
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
No description provided.