Improve <cuda/std/ctime> implementation
#4682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
commented
May 13, 2025
Comment on lines
+51
to
+56
| [[nodiscard]] _CCCL_FORCEINLINE _CCCL_VISIBILITY_HIDDEN _CCCL_HOST_DEVICE clock_t __cccl_clocks_per_sec_impl() noexcept | ||
| { | ||
| NV_IF_ELSE_TARGET(NV_IS_HOST, (return CLOCKS_PER_SEC;), (return clock_t(1'000'000'000);)) | ||
| } | ||
|
|
||
| #define CCCL_CLOCKS_PER_SEC _CUDA_VSTD::__cccl_clocks_per_sec_impl() |
There was a problem hiding this comment.
Alternatively, we could introduce cuda::clocks_per_sec() function, that would be probably a more suitable solution..
There was a problem hiding this comment.
I believe we want something that is valid both on host device if we ever need it
There was a problem hiding this comment.
Yeah, that's what I meant, making this function public in cuda:: namespace, the implementation could stay the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
<cuda/std/ctime>implementation by:std::namespace that don't have problems with being renamed by a macro andCCCL_CLOCKS_PER_SECmacro as an target independent alternative toCLOCKS_PER_SEC