Fix orientation lock setting app to all after closing camera
#105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdogg7
commented
May 22, 2025
| func lockCameraInPortraitOrientation(_ appDelegate: MApplicationDelegate.Type) -> Self { config.appDelegate = appDelegate; manager.attributes.orientationLocked = true; return self } | ||
| func lockCameraInPortraitOrientation(_ appDelegate: MApplicationDelegate.Type) -> Self { | ||
| config.appDelegate = appDelegate | ||
| config.originalOrientationLock = appDelegate.orientationLock |
There was a problem hiding this comment.
Captures the AppDelegate's orientationLock and stores it as a default
| @@ -144,7 +144,7 @@ private extension MCamera { | |||
| } | |||
| private extension MCamera { | |||
| func lockScreenOrientation(_ orientation: UIInterfaceOrientationMask?) { | |||
| config.appDelegate?.orientationLock = orientation ?? .all | |||
| config.appDelegate?.orientationLock = orientation ?? config.originalOrientationLock | |||
There was a problem hiding this comment.
When calling lockScreenOrientation(nil) we will fallback to the original value set in AppDelegate (such as .portrait)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted in issue 89, after closing the
Camera's session we reset theAppDelegate's orientation toall. This change will ensure we reset the orientation to the original state dictated byAppDelegate.