Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action-npm-publish to v5 #255

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Update action-npm-publish to v5 #255

merged 3 commits into from
Feb 12, 2025

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Dec 5, 2024

See changelog for action-npm-publish: https://github.com/MetaMask/action-npm-publish/blob/main/CHANGELOG.md#520

Examples

- Update `actions/cache` to v4
- Update `MetaMask/action-npm-publish` to v5

The only action that we are not upgrading is `actions-gh-pages`. I am
assuming that we are using a specific commit ID for a reason.
@mcmire mcmire marked this pull request as ready for review December 5, 2024 00:04
@mcmire mcmire requested a review from a team as a code owner December 5, 2024 00:04
cryptodev-2s
cryptodev-2s previously approved these changes Dec 5, 2024
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire requested a review from Gudahtt December 12, 2024 21:17
@mcmire mcmire changed the title Use latest versions of actions Update action-npm-publish to v5 Feb 12, 2025
@mcmire
Copy link
Contributor Author

mcmire commented Feb 12, 2025

^ Fixed conflicts.

Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 08a8d65 into main Feb 12, 2025
21 checks passed
@mcmire mcmire deleted the update-action-versions branch February 12, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants