Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add background Redux slice as proxy for unflattened background state #29694

Draft
wants to merge 156 commits into
base: jongsun/refactor/redux/250221-unflattening-types
Choose a base branch
from

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Jan 14, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Define types for metamask controller stores
… are assigned composed controller state objects
…hange` listener and avoid iterating through entire `metamask` slice for every background state update
… and exposes their composed state via `.getState()`
…d state and individual controller states as input
…pdates to the entire background state or top-level non-object properties of background state
…re it can handle the unflattened background state
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250221-unflattening-types branch from e8126fd to 57be00d Compare March 3, 2025 22:12
@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch from d6e9a93 to b493c53 Compare March 3, 2025 22:25
@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250221-unflattening-types branch from 054db29 to 21bdbb2 Compare March 3, 2025 22:30
@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch 3 times, most recently from 49f54c1 to 3625d9e Compare March 3, 2025 23:08
@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch from 3625d9e to 794bf50 Compare March 3, 2025 23:23
@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch from 9d854cd to 5ccf689 Compare March 4, 2025 07:43
@metamaskbot
Copy link
Collaborator

Builds ready [2f24443]
Page Load Metrics (1676 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint50118711624272131
domContentLoaded1484185716568541
load1493187416768943
domInteractive249338178
backgroundConnect105728168
firstReactRender1572342411
getState55612147
initialActions00000
loadScripts1096138912357435
setupStore86819199
uiStartup17232168191710651

@MajorLift MajorLift force-pushed the jongsun/refactor/redux/250221-unflattening-types branch from 21bdbb2 to 5871a01 Compare March 4, 2025 16:33
…jongsun/perf/redux/2501141-add-background-redux-slice
@metamaskbot
Copy link
Collaborator

Builds ready [6d501d9]
Page Load Metrics (1928 ± 144 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint160027251932299144
domContentLoaded157826801881281135
load159027281928300144
domInteractive27116563316
backgroundConnect12172504321
firstReactRender15108412512
getState679242010
initialActions01000
loadScripts120520281428223107
setupStore794232512
uiStartup176737742228455218

@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch 5 times, most recently from 1fd4cac to 8ac2738 Compare March 5, 2025 19:14
@MajorLift MajorLift force-pushed the jongsun/perf/redux/2501141-add-background-redux-slice branch from 8ac2738 to b97221a Compare March 5, 2025 19:29
@metamaskbot
Copy link
Collaborator

Builds ready [b97221a]
Page Load Metrics (1606 ± 51 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33019161487381183
domContentLoaded14121836158810752
load14231847160610751
domInteractive248831147
backgroundConnect85322157
firstReactRender1482432612
getState5589115
initialActions01000
loadScripts1019143411729144
setupStore75314136
uiStartup16602133184011555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants