-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add background
Redux slice as proxy for unflattened background state
#29694
Draft
MajorLift
wants to merge
156
commits into
jongsun/refactor/redux/250221-unflattening-types
Choose a base branch
from
jongsun/perf/redux/2501141-add-background-redux-slice
base: jongsun/refactor/redux/250221-unflattening-types
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: Add background
Redux slice as proxy for unflattened background state
#29694
MajorLift
wants to merge
156
commits into
jongsun/refactor/redux/250221-unflattening-types
from
jongsun/perf/redux/2501141-add-background-redux-slice
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define types for metamask controller stores
… are assigned composed controller state objects
… to use state properties
…mposedState` usage
…hange` listener and avoid iterating through entire `metamask` slice for every background state update
… and exposes their composed state via `.getState()`
…d state and individual controller states as input
…pdates to the entire background state or top-level non-object properties of background state
…re it can handle the unflattened background state
e8126fd
to
57be00d
Compare
d6e9a93
to
b493c53
Compare
054db29
to
21bdbb2
Compare
49f54c1
to
3625d9e
Compare
3625d9e
to
794bf50
Compare
…jongsun/perf/redux/2501141-add-background-redux-slice
9d854cd
to
5ccf689
Compare
Builds ready [2f24443]
Page Load Metrics (1676 ± 43 ms)
|
21bdbb2
to
5871a01
Compare
…jongsun/perf/redux/2501141-add-background-redux-slice
Builds ready [6d501d9]
Page Load Metrics (1928 ± 144 ms)
|
1fd4cac
to
8ac2738
Compare
8ac2738
to
b97221a
Compare
Builds ready [b97221a]
Page Load Metrics (1606 ± 51 ms)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist