Fix upstream bug with dots enabled #5167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrapheneOS/os-issue-tracker#2601 I did not find any issue reported upstream, but I can confirm that this bug exists on Moto App Launcher (the launcher on Motorola's devices), which seems to imply this is a bug in AOSP itself. I had asked @agnostic-apollo about this is a bug, and he said that this is a bug in Android's libraries itself
MrSluffy
approved these changes
Jan 15, 2025
|
LGTM! Thanks for the PR! |
MrSluffy
changed the title
MrSluffy
changed the title
nulldrf
pushed a commit
to nulldrf/lawnchair
that referenced
this pull request
Jan 16, 2025
GrapheneOS/os-issue-tracker#2601 I did not find any issue reported upstream, but I can confirm that this bug exists on Moto App Launcher (the launcher on Motorola's devices), which seems to imply this is a bug in AOSP itself. I had asked @agnostic-apollo about this is a bug, and he said that this is a bug in Android's libraries itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did not find any issue reported upstream, but I can confirm that this bug exists on Moto App Launcher (the launcher on Motorola's devices). Further there is an issue on GrapheneOS issue tracker, which seems to imply this is a bug in AOSP itself. I had asked @agnostic-apollo about this is a bug, and he said that this is a bug in Android's libraries itself. I'm not a Android dev, so feel free to suggest any changes to the PR.
With this change, I was able to use Lawnchair without any crashes for around 24+ hours with notification dots on. So, I guess this workaround works
Works around GrapheneOS/os-issue-tracker#2601
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
✅ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)