Skip to content

Fix warnings, move to c++17, consistent include guards, clean up (some) includes #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

ebchin
Copy link
Member

@ebchin ebchin commented Jun 3, 2025

This PR

  • Clears all warnings up to clang 20
  • Introduces new array types in common/Memory.hpp and common/Arrays.hpp, tests in tests/tribol_memory.cpp and tests/tribol_containers.cpp, and benchmarks in examples/array_benchmarks.cpp
  • Introduces geometric primitives in geom/Vector.hpp and geom/Hyperplane.hpp which handle operations on these commonly used types
  • Removes tribol::StackArray in favor of these new array types
  • Replaces variable length C-style arrays with new array types that match the type of data being stored
  • Changes include guard naming to be consistent
  • Removes some of the extraneous header includes in some of the test and source files. Still some work to be done with this.

TODO:

  • Documentation
  • Benchmark cleanup
  • Constructor clarification for new memory and array types

Follow-on PRs:

  • Further cleanup of extraneous header file includes
  • Convert more arrays to use the new array types and make sure existing usages are clear and in line with the intended usage
  • Add functionality to new array and geometry types as needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant