fix: don't try to use a cross-architecture objdump on the native arch… #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milianw
reviewed
May 29, 2025
| return isArm ? QStringLiteral("arm-linux-gnueabi-objdump") : QStringLiteral("objdump"); | ||
| #endif | ||
| #ifndef __arm__ | ||
| if (m_arch.startsWith(QLatin1String("arm"))) { |
There was a problem hiding this comment.
I assume __arm__ will be defined together with __aarch64__, right?
generally though, I wonder if we should instead just do something like this instead:
if (m_arch.startsWith(QLatin1String("armv8")) || m_arch.startsWith(QLatin1String("aarch64"))) {
if (auto aarch64Objdump = QStandardPaths::findExecutable(QStringLiteral("aarch64-linux-gnu-objdump")); !aarch64Objdump.isEmpty()))
return aarch64Objdump;
}
and dito for the other one - this should always work and is independent of the compile time macros? what do you think?
…itecture If the host architecture is aarch64, aarch64-linux-gnu-objdump may not exist, which is the case on at least Fedora and NixOS, so disassembly doesn't work by default. Similar logic likely also applies to arm-linux-gnueabi-objdump. Fix the problem by only trying to use the cross-architecture objdump if it is found in $PATH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…itecture
If the host architecture is aarch64, aarch64-linux-gnu-objdump may not exist, which is the case on at least Fedora and NixOS, so disassembly doesn't work by default. Similar logic likely also applies to arm-linux-gnueabi-objdump. Fix the problem by only trying to use the cross-architecture objdump if we are not building for the given architecture.