-
Notifications
You must be signed in to change notification settings - Fork 586
ADIOS2: Build for both MPICH and MPItrampoline #4749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2: Build for both MPICH and MPItrampoline #4749
Conversation
I'm not sure this built the right set of packages. It doesn't seem to have built separate packages for MPICH and MPItrampoline. I'm marking this as a draft. How do I correct this? |
I think you also need to pass the new platform set to build_tarballs.jl you will also need to declare a dependency on MPIPreferences.jl so best to wait until that is registered. |
This should be good to go now also with regards to MPIPreferences? Or should we fix Lines 11 to 12 in 3128588
|
We need to either wait for JuliaRegistries/RegistryCI.jl#448, or @eschnett ping me after the merge and I will merge it manually into the Registry, I have done all my tests on LAMMPS_jll so I think this |
This might be ready now! |
This is building also for OpenMPI, right? So that
shouldn't be a concern anymore. |
Yes, I added OpenMPI support. The respective tests failed initially, so I assume it's properly tested. |
@vchuravy any objections against merging this now? If not, I'll merge this tomorrow |
No description provided.