Skip to content

ADIOS2: Build for both MPICH and MPItrampoline #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 13, 2022

Conversation

eschnett
Copy link
Contributor

No description provided.

@eschnett eschnett marked this pull request as draft April 13, 2022 00:22
@eschnett
Copy link
Contributor Author

I'm not sure this built the right set of packages. It doesn't seem to have built separate packages for MPICH and MPItrampoline. I'm marking this as a draft. How do I correct this?

@vchuravy
Copy link
Member

I think you also need to pass the new platform set to build_tarballs.jl you will also need to declare a dependency on MPIPreferences.jl so best to wait until that is registered.

@eschnett eschnett marked this pull request as ready for review April 13, 2022 18:34
@giordano
Copy link
Member

This should be good to go now also with regards to MPIPreferences? Or should we fix

# FIXME: When MPIPreferences is registered both `binary` and `abi` should be const
# and the jll packages using this tag shall depend on MPIPreferences.jl
first?

@vchuravy
Copy link
Member

vchuravy commented Apr 14, 2022

We need to either wait for JuliaRegistries/RegistryCI.jl#448, or @eschnett ping me after the merge and I will merge it manually into the Registry,

I have done all my tests on LAMMPS_jll so I think this LGTM, except that we should add OpenMPI support to avoid JuliaPackaging/JLLWrappers.jl#40 becoming a problem immediately.

@eschnett
Copy link
Contributor Author

eschnett commented May 9, 2022

This might be ready now!

@giordano
Copy link
Member

giordano commented May 9, 2022

This is building also for OpenMPI, right? So that

except that we should add OpenMPI support to avoid JuliaPackaging/JLLWrappers.jl#40 becoming a problem immediately.

shouldn't be a concern anymore.

@eschnett
Copy link
Contributor Author

eschnett commented May 9, 2022

Yes, I added OpenMPI support. The respective tests failed initially, so I assume it's properly tested.

@giordano giordano requested a review from vchuravy May 9, 2022 23:02
@giordano
Copy link
Member

@vchuravy any objections against merging this now? If not, I'll merge this tomorrow

@giordano giordano merged commit 6c844a1 into JuliaPackaging:master May 13, 2022
@eschnett eschnett deleted the eschnett/adios2-mpi branch June 12, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants