This repository was archived by the owner on Aug 16, 2023. It is now read-only.
[WIP] refactor into const globals #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
reviewed
Apr 24, 2019
| # Initialize our global_prefix | ||
| global_prefix = Prefix(joinpath(dirname(pathof(@__MODULE__)), "..", "global_prefix")) | ||
|
|
||
| path = joinpath(@__DIR__, "..", "global_prefix") |
There was a problem hiding this comment.
See #156 for my alternative fix. (Though I actually prefer your version personally.)
|
This refactor IMO is a lot more readable than all the globals in the current code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove lots of closures and untyped globals, which may or may not be faster and more readable.
It at least composes a bit better, to directly call into the underlying libraries for downloads + compression.
Last remaining thing that needs to be done is to incorporate the ENV overwrite. I couldn't figure out on first sight how they're supposed to work :D