-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use internal jl_set_const to create constants #125
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 10 10
Lines 1923 1923
=======================================
Hits 1523 1523
Misses 400 400 ☔ View full report in Codecov by Sentry. |
It would be nice to get this reviewed and merge relatively quickly, so that we can unblock JuliaLang/julia#57150. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
07261b0
to
b4461b3
Compare
I took the liberty of rebasing so it can be tested with multiple threads. |
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
b4461b3
to
52d5703
Compare
The internal function
jl_set_const
is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.