Don't use internal jl_set_const to create constants #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 10 10
Lines 1923 1923
=======================================
Hits 1523 1523
Misses 400 400 ☔ View full report in Codecov by Sentry. |
|
It would be nice to get this reviewed and merge relatively quickly, so that we can unblock JuliaLang/julia#57150. |
JamesWrigley
force-pushed
the
kf/jlsetconst
branch
from
07261b0 to
b4461b3
Compare
|
I took the liberty of rebasing so it can be tested with multiple threads. |
The internal function `jl_set_const` is allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.
JamesWrigley
force-pushed
the
kf/jlsetconst
branch
from
b4461b3 to
52d5703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal function
jl_set_constis allowed during bootstrap only and ignores world age partition. This would give incorrect results after JuliaLang/julia#57150. Just eval the constant definition directly, which has well defined semantics.