Add EnzymeCore extension #536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maleadt all passed locally :) |
maleadt
requested changes
May 28, 2024
wsmoses
force-pushed
the
master
branch
2 times, most recently
from
0a135c0 to
5156198
Compare
|
@maleadt can this get a review? |
maleadt
requested changes
Jun 4, 2024
test/gpuarrayscore.jl
Outdated
Comment on lines
4
to
8
| @test nothing == EnzymeCore.EnzymeRules.inactive_noinl(GPUArraysCore.assertscalar) | ||
|
|
||
| @test nothing == EnzymeCore.EnzymeRules.inactive_noinl(GPUArraysCore.default_scalar_indexing) | ||
|
|
||
| @test nothing == EnzymeCore.EnzymeRules.inactive_noinl(GPUArraysCore.allowscalar, identity) |
There was a problem hiding this comment.
Testing for the exact definition of interface methods isn't good testing. We don't want to have to update tests every time implementation details (of Enzyme or GPUArrays) change. Instead, this should test for observed, meaningful behavior (i.e., why are these definitions needed in the first place).
|
CI failure related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.