Removed TxField #5120
Draft
Removed TxField #5120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/generic-updates-removal
branch
from
452c5ff to
0f11d04
Compare
lehins
reviewed
Jun 16, 2025
| @@ -399,6 +401,11 @@ instance Era era => Monoid (TxDats era) where | |||
| -- | Encodes memoized bytes created upon construction. | |||
| instance Era era => EncCBOR (TxDats era) | |||
|
|
|||
| instance Era era => IsList (TxDats era) where | |||
| type Item (TxDats era) = Data era | |||
| fromList = foldr' (\x -> (TxDats (Map.singleton (hashData x) x) <>)) mempty | |||
There was a problem hiding this comment.
We have a nice fromElems helper for this
Suggested change
| fromList = foldr' (\x -> (TxDats (Map.singleton (hashData x) x) <>)) mempty | |
| fromList = TxDats . fromElems hashData |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).