test: Added more unit test for some CLI options and some database connections #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
helensilva14
previously requested changes
Feb 3, 2025
There was a problem hiding this comment.
Thanks a lot for your contribution @safe049! I did an overall review since I'm not very acquainted with the CLI unit tests, hopefully @nj1973 or @sundar-mudupalli-work could review them in more technical detail.
But seeing how early our Cloud Build check failed, you probably still need to lint & format your files and you can use our script ./tests/local_check.sh for that. Let me know if you need help!
…unit tests in main and cli_tools
|
I removed those buggy function and a useless import, I think it will be alright now |
|
/gcbrun |
helensilva14
dismissed
their stale review
I don't have enough context to evaluate the specific CLI unit tests, I'll be assigning to other team member
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more unit test for CLI options
Added unit test for Oracle, PostgreSQL, SQLserver, SQLite, MariaDB, DB2, MongoDB, Cassandra 's connection