chore: Add initial templates for new issues and pull requests #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helensilva14
changed the title
|
/gcbrun |
helensilva14
changed the title
|
/gcbrun |
helensilva14
requested review from
nehanene15,
nj1973 and
sundar-mudupalli-work
|
/gcbrun |
nehanene15
reviewed
Feb 4, 2025
| ## Checklist | ||
| - [ ] I have followed the [`CONTRIBUTING` Guide](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/CONTRIBUTING.md). | ||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] I have successfully run the E2E tests, and have included the outcomes in the PR comments |
There was a problem hiding this comment.
I feel like some people (especially external contributors) use PRs as a way of running the tests.. so maybe that shouldn't be a checklist item.
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
| - [ ] I have successfully run the E2E tests, and have included the outcomes in the PR comments | ||
| - [ ] I have added tests that prove my fix is effective or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes (suggestion: use the `tests/local_check.sh` script) |
There was a problem hiding this comment.
I think we can remove this since the bullet above should imply the tests work 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1349
Closes #1350