vlan: toggle vlan configuration in debian packaging #495
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dorileo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We are enabling vlan support by default for debian systems. Note we are not forcing overwriting the configuration for updated instances, user will need to manually toggle the configuration for long running instances if they need/want to enable it.
dorileo
force-pushed
the
vlan-default-config
branch
from
46ba857 to
6d5f5d7
Compare
| @@ -36,6 +36,7 @@ dhclient_script = /sbin/google-dhclient-script | |||
| dhcp_command = | |||
| ip_forwarding = true | |||
| setup = true | |||
| # vlan_setup_enabled = false | |||
There was a problem hiding this comment.
why is this commented out? Default should anyways be false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are enabling vlan support by default for debian systems. Note we are not forcing overwriting the configuration for updated instances, user will need to manually toggle the configuration for long running instances if they need/want to enable it.