Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

maxsrli
Copy link

@maxsrli maxsrli commented Jan 3, 2021

Hi,

I understand this issue has been raised in one of the previous pull requests.

However, I think adding a context menu would be very useful, for example:

  • UC1: Given a user has no, or difficult access to a keyboard (using a wireless mouse, remote projecting, etc), the user can enable PiP mode simply through the context menu.
  • UC2: Given a user with conflicting keyboard shortcut, the user do not need to re-assign a new shortcut, and can enable PiP mode simply through the context menu.

Moreover, I have also added an option to disable the context menu for users that do not want this feature, the option can be found under Extension options.

Please consider adding this feature, thanks.

Added context menu to toggle PiP when user clicks on `page` or `video`. WIth an option to disable this feature in extension settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant