Fix message ports not being closed when proxy is relased #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @surma @benjamind |
|
Would be nice to see this merged. Is there anything blocking it? |
|
Mostly that myself and @surma are too busy to look at it. Apologies for that. We need more maintainers for this project! |
benjamind
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression that was introduced in #653 in that releasing a proxy would not close the underlying message port endpoints. The reason for this was that
requestResponseMessagewas called with a new Map, causing the returned promise to never settle and preventingcloseEndpoint(ep)from being called.This PR fixes this by making sure that we always pass the endpoint's pending listeners to the
requestResponseMessagefunction. Both the endpoint and its pending listeners are now passed as a single object to all relevant functions to reflect the tight coupling between those.