Fix inferring the crate name #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation assumed that we always have a top level crate, which cannot be assumed in general. We now reverse the path and try striping everything including `src`. Afterwards we assume that the directory on top of that is the parent crate name. That's still hacky, but works for our use-case. For a better solution we would query cargo-metadata for informations and then use that to resolve the crate names.
SwishSwushPow
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation assumed that we always have a top level crate, which cannot be assumed in general. We now reverse the path and try striping everything including
src. Afterwards we assume that the directory on top of that is the parent crate name. That's still hacky, but works for our use-case. For a better solution we would query cargo-metadata for informations and then use that to resolve the crate names.