Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

[BUGFIX] only register (Sub)PageLanguageOverlayProvider if pagesLanguageConfigurationOverlay is activated #350

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

franzkugelmann
Copy link
Contributor

If setting pagesLanguageConfigurationOverlay = 0 then in this project all fluidpages configuration is done only in the default language. Thus the (Sub)PageLanguageOverlayProvider is not needed at all and in fact causes an error

Call to a member function getOption() on null

if the page_language_overlay record is edited.

I am not 100% sure if this assumption is correct, but solves the problem in my instance without creating other issues, as far as i can see.

@NamelessCoder
Copy link
Member

I did a little change to make sure the providers only load when the option is explicitly enabled. Honestly, I thought these providers were already excluded from loading when the option was off - it definitely isn't the intention to have those running if you disable that option!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants