Skip to content

jhw merge request #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 95 commits into
base: main
Choose a base branch
from
Open

jhw merge request #784

wants to merge 95 commits into from

Conversation

jiahuiwen-baai
Copy link

operation update

# log_dir = os.path.join(gems_repo, "benchmark",
# f"result_test_tensor_concat_perf--level_core--mode_{mode}--warmup_{warmup}--record_log.log")
log_dir = os.path.join(gems_repo, "benchmark", f"result--level_core--mode_{mode}--warmup_{warmup}--record_log.log")
save_log_path = os.path.join(result_log_dir, "result.log.txt")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要再写一遍到另一个文件中,后续直接读 gems 生成的文件即可

flaggems_dir = os.getenv("FLAGGEMS_WORK_DIR", "/")
gems_repo = subprocess.check_output(
["find", flaggems_dir, "-type", "d", "-name", "FlagGems"], text=True).strip()
p = subprocess.Popen(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开始前先删除一下之前的log 日志,以免混淆

result_data = get_result_data(log_file, res, spectflops, mode, warmup)
file_r.seek(0)
file_r.write(json.dumps(result_data, ensure_ascii=False))
file_r.truncate()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是想合并两次的结果?

@@ -0,0 +1,41 @@
# Copyright (c) 2024 BAAI. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件换个文件名

operation/run.py Outdated
@@ -371,7 +371,7 @@ def summary_logs(config, case_log_dir):
result[host]["vendor"] = vendor_log

# system monitor results like CPU/MEM/POWER
for index in ["cpu", "mem", "pwr"]:
for index in ["cpu", "mem"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动的原因是?

operation/run.py Outdated
.format(node, round(np.mean(pwr_series), 2),
round(np.max(pwr_series), 2),
round(np.std(pwr_series), 2)))
# RUN_LOGGER.info("2) POWER:")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@@ -201,8 +201,8 @@ def start_tasks_in_cluster(dp_path, container_name, config, base_args,
nnodes = len(config.HOSTS)
framework = config.CASES[case]

op, df, spectflops, oplib, chip = case.split(":")
env_dir = os.path.join(config.FLAGPERF_PATH, "benchmarks", op,
test_file, op, df, spectflops, oplib, chip = case.split(":")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样改,第一版是不是就不支持了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants