Skip to content

Commit

Permalink
update to latest rxfire
Browse files Browse the repository at this point in the history
  • Loading branch information
jhuleatt committed Sep 15, 2021
1 parent 8f8fd08 commit 7eded08
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"typescript": "^4.2.4"
},
"dependencies": {
"rxfire": "^6.0.0",
"rxfire": "^6.0.2",
"rxjs": "^6.6.3 || ^7.0.1"
},
"resolutions": {
Expand Down
2 changes: 0 additions & 2 deletions src/functions.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ export function useCallableFunctionResponse<RequestData, ResponseData>(
const functions = useFunctions();
const observableId = `functions:callableResponse:${functionName}:${JSON.stringify(options?.data)}:${JSON.stringify(options?.httpsCallableOptions)}`;
const obsFactory = rxHttpsCallable<RequestData, ResponseData>(functions, functionName, options?.httpsCallableOptions);

//@ts-expect-error because RxFire doesn't make data optional. Remove when https://github.com/FirebaseExtended/rxfire/pull/34 is released.
const observable$ = obsFactory(options?.data);

return useObservable(observableId, observable$, options);
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10637,10 +10637,10 @@ run-queue@^1.0.0, run-queue@^1.0.3:
dependencies:
aproba "^1.1.1"

rxfire@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/rxfire/-/rxfire-6.0.0.tgz#298d6bba7963d2338a51bac6930c88192e345a42"
integrity sha512-COpH7vtMrxc+iKqUS1A6CEZMJwIpMM/3H1jnKjYAhzhHQG1YaJYH4Q8EcMMNd0ZX7l8ag6hW1ppoB7j9ctJyfA==
rxfire@^6.0.2:
version "6.0.2"
resolved "https://registry.yarnpkg.com/rxfire/-/rxfire-6.0.2.tgz#2edf59e1b35401503e1bef368c40cbc17f1afb53"
integrity sha512-4Ob30tYy88sEDk92QzKznVvNjB13T0Z30aCC5hWkekaW2SzR3OHr4LO74IFGw7c/PoDUmQTzwwnncjq56pfOrQ==
dependencies:
tslib "^1.9.0 || ~2.1.0"

Expand Down

0 comments on commit 7eded08

Please sign in to comment.