Skip to content

1.19/dev #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2022
Merged

1.19/dev #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e80c952
build: version -> 1902.1.14, updated changelog
desht Dec 12, 2022
d44e679
fix: do rank tab completion via server-side suggestions
desht Dec 12, 2022
4913d40
fix: couple of small text component fixes for rank showing
desht Dec 12, 2022
fe30416
fix: one more text formatting fix
desht Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

[1902.1.14]

### Fixed
* Backed out dynamic tab-completion functionality and use simple server-side suggestions instead
* FTB Ranks is a server-only mod again and no longer needs to be installed on the client since that's unnecessarily disruptive

[1902.1.13]

### Fixed
Expand Down
125 changes: 76 additions & 49 deletions common/src/main/java/dev/ftb/mods/ftbranks/FTBRanksCommands.java
View file
Open in desktop

Large diffs are not rendered by default.

110 changes: 0 additions & 110 deletions common/src/main/java/dev/ftb/mods/ftbranks/RankArgumentType.java
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions common/src/main/resources/assets/ftbranks/lang/en_us.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions fabric/src/main/java/dev/ftb/mods/ftbranks/fabric/FTBRanksFabric.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,9 @@

import dev.ftb.mods.ftbranks.FTBRanks;
import dev.ftb.mods.ftbranks.MessageDecorator;
import dev.ftb.mods.ftbranks.RankArgumentType;
import net.fabricmc.api.ModInitializer;
import net.fabricmc.fabric.api.command.v2.ArgumentTypeRegistry;
import net.fabricmc.fabric.api.message.v1.ServerMessageDecoratorEvent;
import net.minecraft.network.chat.MutableComponent;
import net.minecraft.resources.ResourceLocation;

import java.util.concurrent.CompletableFuture;

Expand All @@ -16,9 +13,6 @@ public class FTBRanksFabric implements ModInitializer {
public void onInitialize() {
new FTBRanks();

ArgumentTypeRegistry.registerArgumentType(new ResourceLocation(FTBRanks.MOD_ID, "rank"),
RankArgumentType.class, new RankArgumentType.Info());

ServerMessageDecoratorEvent.EVENT.register(ServerMessageDecoratorEvent.STYLING_PHASE, (sender, message) -> {
if (sender != null) {
MutableComponent mutableComponent = message.copy();
Expand Down
6 changes: 4 additions & 2 deletions forge/src/main/java/dev/ftb/mods/ftbranks/forge/FTBRanksForge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.ServerChatEvent;
import net.minecraftforge.event.entity.player.PlayerEvent;
import net.minecraftforge.fml.IExtensionPoint.DisplayTest;
import net.minecraftforge.fml.ModLoadingContext;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext;
import net.minecraftforge.network.NetworkConstants;

@Mod(FTBRanks.MOD_ID)
public class FTBRanksForge {
Expand All @@ -26,7 +29,7 @@ public FTBRanksForge() {
// Nope.
// PermissionAPI.setPermissionHandler(new PermissionAPIWrapper(PermissionAPI.getPermissionHandler()));

ModArgumentTypeInfo.ARGUMENT_TYPE_INFO.register(FMLJavaModLoadingContext.get().getModEventBus());
ModLoadingContext.get().registerExtensionPoint(DisplayTest.class, () -> new DisplayTest(() -> NetworkConstants.IGNORESERVERONLY, (a, b) -> true));
}

private void playerNameFormatting(PlayerEvent.NameFormat event) {
Expand All @@ -42,7 +45,6 @@ private void serverChat(ServerChatEvent event) {
event.setMessage(text);
}
}

}

}
17 changes: 0 additions & 17 deletions forge/src/main/java/dev/ftb/mods/ftbranks/forge/ModArgumentTypeInfo.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ org.gradle.daemon=false
mod_id=ftbranks
archives_base_name=ftb-ranks
maven_group=dev.ftb.mods
mod_version=1902.1.13
mod_version=1902.1.14
mod_author=FTB Team

minecraft_version=1.19.2
Expand Down