1.19/dev #31
Merged
1.19/dev #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Events are fired when config is reloaded, when ranks are added/deleted, and when players are added/removed to ranks. Mods can listen for these events and upload their state as necessary based on what permissions players now have.
Added events for permission nodes and rank condition changes
Added subcommands for setting/removing permission nodes and conditions
Added command completion for known ranks, used by all commands which need a rank name
Renamed Rank{Add,Remove}PlayerEvent to Player{AddedTo,RemoveFrom}RankEvent
Added en_us translations
Dump information about a rank in readable form
Also updated build.yml for newer checkout & setup-java actions
(Including 1.19 argument type porting)
No longer attempting to modify the text to change player name formatting; instead, simply override player.getDisplayName() (via Forge event or Fabric mixin).
Not necessary and was only added while testing various chat formatting solutions.
MichaelHillcox
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events, more commands, and fixed chat name formatting in 1.19