FEAT: transient variables #379
Open
+65
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 75.99% 76.00% +0.01%
==========================================
Files 33 33
Lines 5473 5477 +4
==========================================
+ Hits 4159 4163 +4
Misses 1314 1314 ☔ View full report in Codecov by Sentry. |
takluyver
reviewed
Feb 3, 2025
Comment on lines
+74
to
+75
| - `transient` (bool): whether or not to save the variable's result to the | ||
| database. This is useful for e.g. intermediate results. By default variables |
There was a problem hiding this comment.
"whether or not to save" implies that True means save.
I imagine most users will be familiar with the word transient anyway, so the flip will be obvious, but maybe we could either reword this ("whether or not to skip saving"), or change the sense of the parameter (saved=False).
|
Other than quibbling over naming & documentation, this LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controversial one 🙈
Transient variables' data and summary are not saved.