Basic row filtering

[tmichela]

Implements basic row filtering based on column values, there are more requirements for this feature, bu that's already a big enough diff and does already something useful.

One regression: support for standalone comments is dropped in the main table. I implemented another table to view them for the proposal that have used them.

damnit-row-filtering.webm

[codecov]

Codecov Report

Attention: Patch coverage is 81.55340% with 95 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (64c80c2) to head (6f1c1e5).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
damnit/gui/table_filter.py	80.28%	69 Missing ⚠️
damnit/gui/table.py	57.89%	16 Missing ⚠️
damnit/gui/standalone_comments.py	89.15%	9 Missing ⚠️
damnit/gui/plot.py	96.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   76.10%   75.68%   -0.43%     
==========================================
  Files          33       35       +2     
  Lines        5511     5901     +390     
==========================================
+ Hits         4194     4466     +272     
- Misses       1317     1435     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JamesWrigley]

This is more code than I can properly review in one go, but I tested it locally and it works really nicely 🎉 One thing I noticed is that the comment column can't be filtered categorically? That seems a bit odd because other string columns can be and the comment column is basically a string column.

Also, please either do a squash merge or clean up the commits before merging. I semi-regularly do bisects and git blames and these kind of commits really hinder that 😅

[tmichela]

please either do a squash merge or clean up the commits before merging

I cleaned up the commit history

I noticed is that the comment column can't be filtered categorically?

Oh, well spotted, I get all UserRole data, but the data on the comment column is EditRole, I'll add a fix for that.

[JamesWrigley]

LGTM!

[tmichela]

Thanks!