Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report flag button + fix collapse on comments #356

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

Itaybre
Copy link
Collaborator

@Itaybre Itaybre commented Feb 5, 2025

No description provided.

Copy link

emerge-tools bot commented Feb 5, 2025

3 builds increased size

Name Version Download Change Install Change Approval
HackerNews
com.emergetools.hackernews
3.6 (1) 3.7 MB ⬆️ 13.3 kB (0.37%) 6.2 MB ⬆️ 31.0 kB (0.52%) N/A
⚠️ HackerNews
com.emergetools.hackernews.snapshots
3.6 (1) 4.6 MB ⬆️ 38.6 kB (0.85%) 11.1 MB ⬆️ 235.3 kB (2.19%) N/A
HackerNews
com.emergetools.hackernews.adhoc
3.6 (1) 3.7 MB ⬆️ 13.1 kB (0.35%) 6.5 MB ⬆️ 30.9 kB (0.49%) N/A

HackerNews 3.6 (1)
com.emergetools.hackernews

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 31.0 kB (0.52%)
Total download size change: ⬆️ 13.3 kB (0.37%)

Largest size changes

Item Install Size Change
📝 HackerNews.LoadingView.body ⬆️ 4.3 kB
HackerNews.CommentsHeader.body ⬆️ 2.5 kB
HackerNews.CommentRow.body ⬆️ 2.5 kB
📝 WKNavigationDelegate.Objc Metadata ⬆️ 2.0 kB
SwiftUI.View.View ⬆️ 1.1 kB
View Treemap

Image of diff

HackerNews 3.6 (1)
com.emergetools.hackernews.snapshots

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 235.3 kB (2.19%)
Total download size change: ⬆️ 38.6 kB (0.85%)

Largest size changes

Item Install Size Change
DYLD.String Table ⬆️ 126.4 kB
Code Signature ⬆️ 6.1 kB
📝 HackerNews.LoadingView.body ⬆️ 6.0 kB
SwiftUI.ModifiedContent ⬆️ 4.2 kB
HackerNews.CommentRow.body ⬆️ 3.8 kB
View Treemap

Image of diff

HackerNews 3.6 (1)
com.emergetools.hackernews.adhoc

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 30.9 kB (0.49%)
Total download size change: ⬆️ 13.1 kB (0.35%)

Largest size changes

Item Install Size Change
📝 HackerNews.LoadingView.body ⬆️ 4.3 kB
HackerNews.CommentsHeader.body ⬆️ 2.5 kB
HackerNews.CommentRow.body ⬆️ 2.5 kB
📝 WKNavigationDelegate.Objc Metadata ⬆️ 2.0 kB
SwiftUI.View.View ⬆️ 1.1 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

Copy link

emerge-tools bot commented Feb 5, 2025

📸 Snapshot Test

20 modified, 1 added, 68 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
HackerNews
com.emergetools.hackernews.snapshots
1 0 20 0 50 0 ⏳ Needs approval
HackerNews
com.emergetools.hackernews
0 0 0 0 0 0 N/A
HackerNews Swift-Snapshot-Testing
com.emerge.hn.Hacker-News.swiftsnapshottesting
0 0 0 0 18 0 N/A
HackerNews
com.emergetools.hackernews.adhoc
0 0 0 0 0 0 N/A

🛸 Powered by Emerge Tools

@Itaybre Itaybre merged commit e8adec6 into main Feb 6, 2025
5 of 6 checks passed
@Itaybre Itaybre deleted the feature/report_feature branch February 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants